_OpenClient() should return zero on connection failure, not error

2024-07-04 04:50:22 +00:00 · 2022-11-20 18:44:24 -05:00 · 2022-11-20 18:44:24 -05:00 · 11a5b8be8e
parent 445408d95b
commit 11a5b8be8e
4 changed files with 1 additions and 5 deletions
--- a/internal/c/libqb.cpp
+++ b/internal/c/libqb.cpp
@ -28952,7 +28952,7 @@ int32 connection_new(int32 method, qbs *info_in, int32 value) {
            if (err) {
                list_remove(special_handles, my_handle);
                // There's no good way to report the HTTP error here
-                return -1;
+                return 0;
            }

            special_handle_struct *my_handle_struct;
--- a/tests/compile_tests/http/http_error.output
+++ b/tests/compile_tests/http/http_error.output
@ -1,4 +1,3 @@
-Error: 5 , Line: 6 
 0 
 -2 
 404 
--- a/tests/compile_tests/http/invalid_url.output
+++ b/tests/compile_tests/http/invalid_url.output
@ -1,4 +1,2 @@
-Error: 5 , Line: 6 
 0 
-Error: 5 , Line: 10 
 0 
--- a/tests/compile_tests/http/no_unstable_err.output
+++ b/tests/compile_tests/http/no_unstable_err.output
@ -1,2 +1 @@
-Error: 5 , Line: 4 
 0