QB64/QB64-PE
QB64/QB64-PE
1
1
Fork 0
mirror of https://github.com/QB64-Phoenix-Edition/QB64pe.git synced 2024-07-01 16:10:39 +00:00
Code Issues Releases Wiki Activity

Merge pull request #67 from SteveMcNeill/main

Browse source 
Fix to endless loop in retrieving search History
This commit is contained in:
Steve McNeill 2022-05-18 05:30:13 -04:00 committed by GitHub
parent b44bd54db9 d0435fb629
commit 3edbc4a11e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
source/ide/ide_methods.bas
View file

@ -10276,22 +10276,7 @@ FUNCTION idechange$
a2$ = idefindtext
END IF
'retrieve search history
ln = 0
fh = FREEFILE
OPEN ".\internal\temp\searched.bin" FOR BINARY AS #fh: a$ = SPACE$(LOF(fh)): GET #fh, , a$
CLOSE #fh
a$ = RIGHT$(a$, LEN(a$) - 2)
DO WHILE LEN(a$)
ai = INSTR(a$, CRLF)
IF ai THEN
f$ = LEFT$(a$, ai - 1): IF ai = LEN(a$) - 1 THEN a$ = "" ELSE a$ = RIGHT$(a$, LEN(a$) - ai - 3)
ln = ln + 1
REDIM _PRESERVE SearchHistory(1 TO ln)
SearchHistory(ln) = f$
END IF
LOOP
ln = 0
RetrieveSearchHistory SearchHistory()
i = 0
idepar p, 60, 14, "Change"
@ -11131,22 +11116,7 @@ FUNCTION idefind$
a2$ = idefindtext
END IF
'retrieve search history
ln = 0
fh = FREEFILE
OPEN ".\internal\temp\searched.bin" FOR BINARY AS #fh: a$ = SPACE$(LOF(fh)): GET #fh, , a$
CLOSE #fh
a$ = RIGHT$(a$, LEN(a$) - 2)
DO WHILE LEN(a$)
ai = INSTR(a$, CRLF)
IF ai THEN
f$ = LEFT$(a$, ai - 1): IF ai = LEN(a$) - 1 THEN a$ = "" ELSE a$ = RIGHT$(a$, LEN(a$) - ai - 3)
ln = ln + 1
REDIM _PRESERVE SearchHistory(1 TO ln)
SearchHistory(ln) = f$
END IF
LOOP
ln = 0
RetrieveSearchHistory SearchHistory()
i = 0
idepar p, 60, 11, "Find"
@ -20013,6 +19983,19 @@ FUNCTION GetBytes$(__value$, numberOfBytes&)
getBytesPosition& = getBytesPosition& + numberOfBytes&
END FUNCTION
SUB RetrieveSearchHistory (SearchHistory() as string)
fh = FREEFILE
OPEN ".\internal\temp\searched.bin" FOR BINARY AS #fh
redim _preserve SearchHistory(1 to 10000) 'large initial array to hold the data
Do until eof(fh)
ln = ln + 1
if ln > ubound(SearchHistory) then redim _preserve SearhHistory(1 to ln + 10000) 'large resize, it necessary
line input #fh, SearchHistory(ln)
Loop
redim _preserve SearchHistory(1 to ln) 'resize to proper size before exit
CLOSE #fh
end sub
'FUNCTION Download$ (url$, outputVar$, lookFor$, timelimit) STATIC
' 'as seen on http://www.qb64.org/wiki/Downloading_Files
' 'adapted for use in the IDE